Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the copy package to avoid collision with reserved golang term #26539

Closed
atoulme opened this issue Sep 8, 2023 · 5 comments
Closed

Rename the copy package to avoid collision with reserved golang term #26539

atoulme opened this issue Sep 8, 2023 · 5 comments

Comments

@atoulme
Copy link
Contributor

atoulme commented Sep 8, 2023

Component(s)

pkg/stanza

Describe the issue you're reporting

The package https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/stanza/operator/transformer/copy/ uses the reserved word "copy" as package name, which makes the linter predeclared fail.

  1. Remove the exclusion from .golangci.yml by removing those lines:
        predeclared:
    ignore: copy
  1. Rename the package so the linter no longer fails.
@atoulme atoulme added the needs triage New item requiring triage label Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

github-actions bot commented Nov 8, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 8, 2023
Copy link
Contributor

github-actions bot commented Jan 7, 2024

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 7, 2024
@atoulme atoulme reopened this Jan 7, 2024
@djaglowski
Copy link
Member

I'd prefer not to make any change here because it would be breaking. The package is named consistently with other operators and it seems like a simple enough exception to note in the linter config.

@djaglowski
Copy link
Member

Closing as not planned. Please reopen if you feel strongly about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants