Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter/fileexporter: Ability to add custom Log and Metric Marshalers #30331

Open
sinkingpoint opened this issue Jan 8, 2024 · 6 comments
Open
Assignees
Labels

Comments

@sinkingpoint
Copy link
Contributor

sinkingpoint commented Jan 8, 2024

Component(s)

exporter/fileexporter

Is your feature request related to a problem? Please describe.

Similar to #14514 , it would be useful to be able to extend the file exporters list of marshalers without having to fork the exporter. Concretely, our usecase is to export syslog formatted logs to a file for our auditing pipeline.

Describe the solution you'd like

Similarly to #16514 , I'd like to introduce factory options that allow custom marshalers on top of the existing json and proto

Describe alternatives you've considered

We could submit some of these marshalers to the contrib repo, but there are quite a few usecases here for weird marshalers so it seems impractical to manage them all here

Additional context

No response

@sinkingpoint sinkingpoint added enhancement New feature or request needs triage New item requiring triage labels Jan 8, 2024
@sinkingpoint
Copy link
Contributor Author

/cc @atingchen

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Mar 11, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2024
@mx-psi mx-psi reopened this Jun 4, 2024
Copy link
Contributor

github-actions bot commented Jun 4, 2024

Pinging code owners for exporter/file: @atingchen. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@mx-psi mx-psi removed the Stale label Jun 4, 2024
@mx-psi
Copy link
Member

mx-psi commented Jun 4, 2024

I support this. However, I would like to see this in a pkg module instead of being exposed directly on the filexporter module itself.

Copy link
Contributor

github-actions bot commented Aug 5, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants