Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: Move duplicated ECS metadata clients into internal/aws #3188

Closed
pingleig opened this issue Apr 21, 2021 · 3 comments
Closed

aws: Move duplicated ECS metadata clients into internal/aws #3188

pingleig opened this issue Apr 21, 2021 · 3 comments
Labels
comp:aws AWS components

Comments

@pingleig
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently there are two places using ECS metadata endpoint to get info like cluster name

  • resourcedetectionprocessor/internal/aws/ecs
  • awsecscontainermetricsreceiver

For #1395 prometheus ecs discovery, we need cluster detection using ECS metada API so user don't need to config it manually. We can't make use of neither components along the pipeline. The extension runs at the start of the pipeline and needs the cluster name to generate a prometheus file sd config for receiver.

Describe the solution you'd like

There is a internal/aws package for sharing common aws specific logic. There is no official ECS metada client (and struct definitions). I think we should merge into the common logic to a package like internal/aws/ecsutil

Describe alternatives you've considered

It's possible to import resource detector processor in other components but it's kind of strange and makes the dependency more complex.

Additional context

N/A

@rmfitzpatrick
Copy link
Contributor

Opened #5994 to meet this requirement

@rmfitzpatrick
Copy link
Contributor

This has been resolved by #5994

@pingleig
Copy link
Contributor Author

@rmfitzpatrick thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:aws AWS components
Projects
None yet
Development

No branches or pull requests

3 participants