Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ImageID in Resource attributes detected by k8sattributes processor #32152

Closed
evantorrie opened this issue Apr 3, 2024 · 4 comments
Closed
Labels
enhancement New feature or request priority:p2 Medium processor/k8sattributes k8s Attributes processor Stale

Comments

@evantorrie
Copy link
Contributor

evantorrie commented Apr 3, 2024

Component(s)

k8sattributes procesor

Is your feature request related to a problem? Please describe.

We currently make use of the k8sattributes processor to augment Resource attributes from pods running in our k8s clusters.

We are interested in obtaining the full sha256 digest version of the image associated with the container in a Kubernetes pod that is emitting telemetry, rather than relying on just the image name + tag.

Describe the solution you'd like

If we include container.id in the k8sattributes::metadata array, we'd like to get not only container.image.name, container.image.tag, but also container.image.id added to the resource for that signal.

Describe alternatives you've considered

Scrape information from kube-state-metrics (which does provide the image digest) and somehow cross-join that with the resource attributes determined by k8sattributes processor?

Additional context

Currently it seems like the k8sattributes processor extracts the image name and image tag from the v1.Pod.Spec.Containers data structure. The image digest is available in v1.Pod.Status.ContainerStatuses[].ImageID.

@evantorrie evantorrie added enhancement New feature or request needs triage New item requiring triage labels Apr 3, 2024
@crobert-1 crobert-1 added the processor/k8sattributes k8s Attributes processor label Apr 3, 2024
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Pinging code owners for processor/k8sattributes: @dmitryax @rmfitzpatrick @fatsheep9146 @TylerHelmuth. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@TylerHelmuth
Copy link
Member

This seems reasonable to me

Copy link
Contributor

github-actions bot commented Jun 4, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@evantorrie
Copy link
Contributor Author

Closed in favor of #34029 Enable populating container_image.repo_digests attribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:p2 Medium processor/k8sattributes k8s Attributes processor Stale
Projects
None yet
Development

No branches or pull requests

3 participants