Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/opampsupervisor] Add support for running as a Windows service #34774

Open
BinaryFissionGames opened this issue Aug 20, 2024 · 3 comments · May be fixed by #35275
Open

[cmd/opampsupervisor] Add support for running as a Windows service #34774

BinaryFissionGames opened this issue Aug 20, 2024 · 3 comments · May be fixed by #35275

Comments

@BinaryFissionGames
Copy link
Contributor

Component(s)

cmd/opampsupervisor

Is your feature request related to a problem? Please describe.

To run a binary as a windows service, it needs to handle the control signals from the Windows service manager.

The supervisor does not currently implement what is needed to run as a Windows service. See https://pkg.go.dev/golang.org/x/sys/windows/svc#Run

Describe the solution you'd like

Implement handling the Windows service signals. See https://github.com/open-telemetry/opentelemetry-collector/blob/main/otelcol/collector_windows.go#L36 for how the collector implements this.

Describe alternatives you've considered

No response

Additional context

No response

@BinaryFissionGames BinaryFissionGames added enhancement New feature or request needs triage New item requiring triage labels Aug 20, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@BinaryFissionGames
Copy link
Contributor Author

/label -needs-triage os:windows

@dpaasman00
Copy link
Contributor

I can take this task on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants