Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you open an OTLP receiver in port 4317, another one is opened on port 55680 #2565

Closed
mirath opened this issue Feb 26, 2021 · 7 comments
Closed
Assignees
Labels
area:receiver discussion-needed Community discussion needed release:required-for-ga Must be resolved before GA release

Comments

@mirath
Copy link

mirath commented Feb 26, 2021

if r.cfg.GRPC.NetAddr.Endpoint == defaultGRPCEndpoint {

Currently if you open an OTLP receiver on port 4317, the code is wired to open an extra one in 55680.

I guess that this was meant as a legacy or backwards compatible feature, but it can trip setups that trying to use 55680 for other uses (it tripped me up while I was doing a proof of concept).

In general I think this is very unintuitive behaviour that is rather tricky to debug.

@pmm-sumo
Copy link
Contributor

pmm-sumo commented Mar 5, 2021

BTW, this was done intentionally as part of #2104 for the transition period

@alolita
Copy link
Member

alolita commented May 11, 2021

@bogdandrutu @bhautikpip submitted a PR to remove support for port 55680. If we decide to deprecate this port, we should do this before GA. Please advise.

cc: @mxiamxia can you please take a look based on what we hear from @bogdandrutu

@bogdandrutu
Copy link
Member

bogdandrutu commented May 14, 2021

@alolita I think we need to agree on the right thing to do here. probably we should discuss this during SIG meeting to achieve agreement.

The first goal is to make a decision.

To understand: "If we release with this it means we have to always support this behavior"

@alolita alolita added release:required-for-ga Must be resolved before GA release discussion-needed Community discussion needed labels May 18, 2021
@alolita
Copy link
Member

alolita commented May 19, 2021

Action Item: We should scan and remove all references in the code and docs to the old port before GA. If we find a reference, file an issue, we will need to fix it.

See: https://github.com/search?q=org%3Aopen-telemetry+55680&type=code

@mxiamxia
Copy link
Member

mxiamxia commented May 21, 2021

OTel Repos need to be updated.

@mxiamxia
Copy link
Member

mxiamxia commented Jun 2, 2021

Removed all the legacy port(55680) mentions across the OpenTelemetry repos. The port will be disabled in OTel Collector v0.30.0 per the discussion below.

#3256 (comment)

@alolita
Copy link
Member

alolita commented Jun 3, 2021

This is completed from an implementation standpoint so I will close this issue. I will open another issue to track user feedback until the Collector reaches version 0.30.0 when this port will be disabled.

@alolita alolita closed this as completed Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:receiver discussion-needed Community discussion needed release:required-for-ga Must be resolved before GA release
Projects
None yet
Development

No branches or pull requests

5 participants