-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jaeger exporter support vs OTel specification #355
Comments
We can also propose to add |
Sounds more in line with what is already done for OTLP. |
Do we want to use one of our own |
Two things of interest that may influence our decision.
I suspect that the protocol environment variable is not in the spec because most languages implemented just one protocol. As a result, I think that we only need to be consistent with the .NET SDK. So maybe we should just rely on the protocol environment variable and say that you need to both set the exporter to jaeger and to set the protocol. And then document that if you don't set the protocol, that grpc will be used, and you will also need to ensure that your application is updated to include the necessary grpc dependencies. |
Just a note that Jaeger exporter over gRPC is not implemented in .NET SDK. So it could e.g. throw an error until it is implemented 🤷 However I would expect to have |
SIG meeting notes We will use Closing this issue as know it is on spec+.NET SDK side. |
For
OTEL_TRACES_EXPORTER
,jaeger
is reserved for an Jaeger exporter using Protobuf via http/thirft or gRPCReferences:
Possible actions
jaeger-dotnet
(sic!) or something similarjaeger
. just add some remark that the usingjaeger
does NOT default to gRPC but UdpCompactThrift protocol (also there is no support for gRPC at the moment)Also
USAGE.md
is outdated and misses info about theOTEL_EXPORTER_JAEGER_ENDPOINT
,OTEL_EXPORTER_JAEGER_PROTOCOL
env vars.Related issue: #255
Origin: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/pull/353/files#r803609447
The text was updated successfully, but these errors were encountered: