Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetryServicesExtensions Location #1642

Closed
lawrence-laz opened this issue Dec 2, 2020 · 3 comments
Closed

OpenTelemetryServicesExtensions Location #1642

lawrence-laz opened this issue Dec 2, 2020 · 3 comments
Labels
pkg:OpenTelemetry.Extensions.Hosting Issues related to OpenTelemetry.Extensions.Hosting NuGet package question Further information is requested

Comments

@lawrence-laz
Copy link

Question

Currently OpenTelemetryServicesExtensions class is located in OpenTelemetry.Extensions.Hosting package. This is a bit unusual, as other packages tend to have ServiceCollection extensions in a package postfixed with Extensions.DependencyInjection or Extensions.Microsoft.DependencyInjection. For example:

  • Autofac.Extensions.DependencyInjection
  • AutoMapper.Extensions.Microsoft.DependencyInjection
  • MediatR.Extensions.Microsoft.DependencyInjection
  • MassTransit.Extensions.DependencyInjection

This doesn't cause any functional problems (as far as I see), but I found it confusing and so might other users. Was OpenTelemetry.Extensions.DependencyInjection considered?

@lawrence-laz lawrence-laz added the question Further information is requested label Dec 2, 2020
@cijothomas
Copy link
Member

The naming was discussed a while ago : #623 (comment)

Please take a look, and see if that makes sense, or do you think we should revisit the name?

@lawrence-laz
Copy link
Author

lawrence-laz commented Dec 9, 2020

Hm, I guess it makes sense once you look into it.

The confusion comes from the fact that hosting service is opaque to the consumer. I wouldn't have thought that there is a hosted service being registered just to kick-start tracing provider. Hence why my instinct was to look for DependencyInjection and not Hosting package.

I don't have a solution here, but I bet I will not be the last one confused.

@cijothomas cijothomas added the pkg:OpenTelemetry.Extensions.Hosting Issues related to OpenTelemetry.Extensions.Hosting NuGet package label Jul 22, 2022
@cijothomas
Copy link
Member

Closing this, as the ext.hosting package is now released as stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Extensions.Hosting Issues related to OpenTelemetry.Extensions.Hosting NuGet package question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants