Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OTLP exporter default to HTTP when metrics and logs are added #2959

Open
pjanotti opened this issue Mar 2, 2022 · 2 comments
Open
Labels
enhancement New feature or request needs-majorversion-bump Issues which requires major version change due to breaking change

Comments

@pjanotti
Copy link
Contributor

pjanotti commented Mar 2, 2022

Feature Request

Follow-up to discussion #2855 - more specifically the suggestion to change the default to HTTP when metrics and logs are both covered by the OTLP exporter, see #2855 (reply in thread)

Motivation for the Change
(Copied from the discussion above)
As per latest spec HTTP is preferred over gRPC, see https://github.com/open-telemetry/opentelemetry-specification/blob/ce50e4634efcba8da445cc23523243cb893905cb/specification/protocol/exporter.md?plain=1#L111-L114 and respective PR discussion: open-telemetry/opentelemetry-specification#1969

There is an exception for already released SDKs but I would like to consider a change for the following reasons:

  1. Anecdata: most usage of OTLP is with HTTP (easier to get correct configuration for load balancers, proxies, etc)
  2. For .NET auto-instrumentation the dependency challenges of earlier versions are harder to deal with, see OTLP Exported as default for .NET (Core) opentelemetry-dotnet-instrumentation#343
    If so, provide a concise description of the problem.

This change should wait for a major bump of the exporter since it is a breaking change.

@pjanotti pjanotti added the enhancement New feature or request label Mar 2, 2022
@cijothomas cijothomas added the needs-majorversion-bump Issues which requires major version change due to breaking change label Mar 2, 2022
Copy link
Contributor

This issue was marked stale due to lack of activity and will be closed in 7 days. Commenting will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Sep 10, 2024
Copy link
Contributor

Closed as inactive. Feel free to reopen if this issue is still a concern.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 17, 2024
@cijothomas cijothomas removed the Stale Issues and pull requests which have been flagged for closing due to inactivity label Sep 18, 2024
@cijothomas cijothomas reopened this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-majorversion-bump Issues which requires major version change due to breaking change
Projects
None yet
Development

No branches or pull requests

2 participants