Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document clearly that Supplier should operate on singly-valued keys #457

Closed
krnowak opened this issue Jan 31, 2020 · 1 comment · Fixed by #467
Closed

Document clearly that Supplier should operate on singly-valued keys #457

krnowak opened this issue Jan 31, 2020 · 1 comment · Fixed by #467
Assignees

Comments

@krnowak
Copy link
Member

krnowak commented Jan 31, 2020

This is mostly a note to self, so I can add the documentation during my work on context propagation. This is to resolve an issue raised in #441.

@krnowak krnowak self-assigned this Jan 31, 2020
@krnowak
Copy link
Member Author

krnowak commented Feb 7, 2020

So this issue conflicts with the following issues in the otel-spec (as we will likely need to rework the supplier interface for allowing multi-valued keys and rework propagator interface to have an iterator over keys instead of a function for getting a fixed list of the keys the propagator uses/understands):

open-telemetry/opentelemetry-specification#433
open-telemetry/opentelemetry-specification#443
open-telemetry/opentelemetry-specification#444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants