-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we omit this annotation entirely if .Values.admissionWebhooks.certManager.enabled=false
instead of setting it to none
?
#1177
Comments
Hey, i would like to work on this issue. |
@suyash-811 Great, we should wait until #1176 is merged. |
Just saw that the PR merged. I'll update the helm template to add the cert-manager annotation if |
I took a look at the template Lines 1 to 6 in 870f231
Thus, i am a bit unsure if this is the file that really needs the change, as the file isnt rendered at all when the cert-manager admissionWebhook is disabled. Or maybe i got something wrong? Either way, looking forward to some feedback! |
@suyash-811 Look for the other places that use the This is going to break |
Ah i see. I'll prepare a PR for this. It can be merged once CRD management is done. |
Originally posted by @TylerHelmuth in #1175 (comment)
The text was updated successfully, but these errors were encountered: