From 0511f5f7c31179fb38e302f2e8fd85e15f4cf09e Mon Sep 17 00:00:00 2001 From: Lauri Tulmin Date: Thu, 12 Oct 2023 14:37:13 +0300 Subject: [PATCH] Suppress exception test should not count as advice failure (#9658) --- .../src/test/java/indy/IndyInstrumentationTest.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/testing-common/integration-tests/src/test/java/indy/IndyInstrumentationTest.java b/testing-common/integration-tests/src/test/java/indy/IndyInstrumentationTest.java index 6d87267c50ac..10a1ebd80976 100644 --- a/testing-common/integration-tests/src/test/java/indy/IndyInstrumentationTest.java +++ b/testing-common/integration-tests/src/test/java/indy/IndyInstrumentationTest.java @@ -8,12 +8,19 @@ import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThatThrownBy; +import io.opentelemetry.instrumentation.testing.junit.AgentInstrumentationExtension; +import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension; +import io.opentelemetry.javaagent.testing.common.TestAgentListenerAccess; import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.extension.RegisterExtension; @SuppressWarnings({"unused", "MethodCanBeStatic"}) public class IndyInstrumentationTest { + @RegisterExtension + static final InstrumentationExtension testing = AgentInstrumentationExtension.create(); + private String privateField; // The following methods are instrumented by the IndyInstrumentationTestModule @@ -92,6 +99,7 @@ void testAssignToReturnViaArray() { @Test void testSuppressException() { assertThat(noExceptionPlease("foo")).isEqualTo("foo_no_exception"); + assertThat(TestAgentListenerAccess.getAndResetAdviceFailureCount()).isEqualTo(2); } @Test