Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge StartTimeExtractor and EndTimeExtractor into one interface #4566

Closed
mateuszrzeszutek opened this issue Nov 2, 2021 · 0 comments · Fixed by #4692
Closed

Merge StartTimeExtractor and EndTimeExtractor into one interface #4566

mateuszrzeszutek opened this issue Nov 2, 2021 · 0 comments · Fixed by #4692
Labels
enhancement New feature or request

Comments

@mateuszrzeszutek
Copy link
Member

Is your feature request related to a problem? Please describe.
The StartTimeExtractor and EndTimeExtractor must always be used together; the InstrumenterBuilder throws if one is set without the other. Perhaps we should merge them into one TimeExtractor interface.

Additional context
#4544 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge start and end time extractors
1 participant
@mateuszrzeszutek