-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "otel.status_description" in WithSpan annotation implementation #6710
Comments
Could you elaborate what you expect to see as the description. |
When there is an exception within the annotated method, the otel.status_description should be set as the exception's message. |
Spec mentions
To me it seems that exception message might not be suitable for Considering that exception message is already present in the exception event you may have a hard time convincing others that it should also be added to |
From my perspective, span status is set to Error, but no description is set up. This SHOULD is not accomplished. |
@laurit this seems like a reasonable request. Is your main concern that the exception message isn't easily "documented and predictable" or is it more around data duplication, or both? |
@breedx-splk As far as I know we never set the description field. If you believe we should, feel free to raise this question at the sig. If we are going to do this we should handle it in the same way everywhere so it won't be tied to just |
I think this is blocked on open-telemetry/opentelemetry-specification#3496 |
Is your feature request related to a problem? Please describe.
When using WithSpan annotation, if there is an exception thrown, the annotation has set the "otel.status_code", but it didn't set the "otel.status_description".
This is important, because the enduser would like to know what cause the error.
Describe the solution you'd like
Set "otel.status_description" when otel.status_code is set as ERROR.
Describe alternatives you've considered
I didn't find the specification about how to give status description. But I see .NET has this, and my commercial endpoint also ask this attributes.
Additional context
#6525
I am able to set up a server and a client, and a local collector, saw the detailed span output.
Status message :
is empty.The text was updated successfully, but these errors were encountered: