You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the log4j1 instrumentation uses otel.instrumentation.log4j-appender.experimental.capture-mdc-attributes, which aligns with the name of the logback/jboss logging configuration
The log4j2 instrumentation uses otel.instrumentation.log4j-appender.experimental.capture-context-data-attributes
can log4j2 instrumentation be updated to use .capture-mdc-attributes, to align it with the log4j1, logback and jboss instrumentation?
Steps to reproduce
n/a
Expected behavior
if I want to capture MDC attributes, I should use `otel.instrumentation.{instrumentation-name}.experimental.capture-mdc-attributes
Actual behavior
log4j2 uses '.capture-context-data-attributes'
Javaagent or library instrumentation version
1.31.0
Environment
JDK: temurin 17 OS: centos
Additional context
No response
The text was updated successfully, but these errors were encountered:
I'm not opposed to this, even though I don't believe Log4j2 calls it "MDC" (either in their API or in their documentation). This could allow us to have a single config, e.g.
Interestingly, the ThreadContext javadoc even calls itself "MDC".
Should we perhaps use a more generic term and rename the properties to otel.instrumentation.common.logging.capture-diagnostic-attributes or otel.instrumentation.common.logging.capture-diagnostic-context-attributes?
Describe the bug
the log4j1 instrumentation uses
otel.instrumentation.log4j-appender.experimental.capture-mdc-attributes
, which aligns with the name of the logback/jboss logging configurationThe log4j2 instrumentation uses
otel.instrumentation.log4j-appender.experimental.capture-context-data-attributes
can log4j2 instrumentation be updated to use
.capture-mdc-attributes
, to align it with the log4j1, logback and jboss instrumentation?Steps to reproduce
n/a
Expected behavior
if I want to capture MDC attributes, I should use `otel.instrumentation.{instrumentation-name}.experimental.capture-mdc-attributes
Actual behavior
log4j2 uses '.capture-context-data-attributes'
Javaagent or library instrumentation version
1.31.0
Environment
JDK: temurin 17
OS: centos
Additional context
No response
The text was updated successfully, but these errors were encountered: