-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opentelemetry operator able to create and mount array of config / configmap [yaml's] instead of single configmap creation #1089
Comments
Beyond specifying multiple YAML configuration blocks, it might also be nice to be able to reference configuration sources by URI to allow loading config from other than a config map created by the operator. |
@Aneurysm9 , maybe if you can add some example to elaborate your statement. But yes, that's a kind of another good suggestion to add on top of this. |
@kabhanus007, bringing the ideas together, I would suggest a third via, like:
|
thanks for suggesting and adding some extra useful stuff to it, it seems a good addition, but a question, how type parameter will be used and are we going to have some fixed constants for that? |
instead of multiple configs, I would rather prefer to let users provide either a single config block, or a set of config URIs. This way, the config file can still be simple for most use cases, while providing a construct for more complex use cases. In such case, users would be required to manage the external sources, including configmaps. |
Yeah, that should also work which will ultimately keep this simple config block the same, but having the capability of extending the functionality of working with multiple configmaps through complex configuration.
Is this something we are looking forward to it? |
is this feature implemented? I have usecase to apply an array of configs (receiver,exportror,service..etc) or could some one help here how to use it if available on both operator as well as collector chart |
cc: @pavankrish123 @jpkrohling
Hi Opentelemetry Operator team,
Background Information
Proposed Solution:
spec.config
for Opentelemetry collector CRD, we propose a new field,configYamls
which is an array of yaml objects instead of single YAML.Sample Implementation:
Once the above configuration is applied, 2 files
prometheusConf.yaml
andotelBaseConf.yaml
will be created in the pod and./otelcorecol --config=file:prometheusConf.yaml --config=file:otelBaseConf.yaml
needs to be executed as start cmd.We use a helm chart to manage these CRD and we would like to leverage this multiple configuration feature to inject multiple configuration from multiple teams through separate helm template files. So far we have been using helm logic to merge these configurations, but it is getting complicated. With this implementation, we can completely eliminate the merge logic from our helm chart.
The text was updated successfully, but these errors were encountered: