From 8b4e15c4fc88c4d8c5c1f8434e07662fcc1a01d6 Mon Sep 17 00:00:00 2001 From: Mihir Gore Date: Tue, 4 May 2021 09:49:07 +0530 Subject: [PATCH] Add review comments. --- .../instrumentation/grpc/grpcext/_interceptor.py | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/grpcext/_interceptor.py b/instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/grpcext/_interceptor.py index d52dd30d4a..a433e56bd1 100644 --- a/instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/grpcext/_interceptor.py +++ b/instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/grpcext/_interceptor.py @@ -13,9 +13,7 @@ # limitations under the License. # pylint:disable=relative-beyond-top-level -# pylint:disable=arguments-differ # pylint:disable=no-member -# pylint:disable=signature-differs """Implementation of gRPC Python interceptors.""" @@ -51,22 +49,16 @@ def __init__(self, method, base_callable, interceptor): def __call__( self, request, - timeout=None, - metadata=None, - credentials=None, - wait_for_ready=None, - compression=None, + **kwargs ): def invoker(request, metadata): return self._base_callable( request, - timeout, - metadata, - credentials, - wait_for_ready, - compression, + **kwargs ) + metadata = kwargs.get("metadata") + timeout = kwargs.get("timeout") client_info = _UnaryClientInfo(self._method, timeout) return self._interceptor.intercept_unary( request, metadata, client_info, invoker