Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Httpx instrumentation results in a connection leak #1694

Closed
sam-mosleh opened this issue Feb 26, 2023 · 0 comments · Fixed by #1695
Closed

Httpx instrumentation results in a connection leak #1694

sam-mosleh opened this issue Feb 26, 2023 · 0 comments · Fixed by #1695
Labels
bug Something isn't working

Comments

@sam-mosleh
Copy link
Contributor

Describe your environment
python 3.10.10
httpx==0.23.3
opentelemetry-instrumentation-httpx==0.36b0

Steps to reproduce

import httpx
from opentelemetry.instrumentation.httpx import HTTPXClientInstrumentor

with httpx.Client() as client:
    HTTPXClientInstrumentor.instrument_client(client)
    print(client.get("https://wtfismyip.com/json").json())

What is the expected behavior?
I expected it to run without any ResourceWarning.

What is the actual behavior?
Got ResourceWarning for each client instance

@sam-mosleh sam-mosleh added the bug Something isn't working label Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant