Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture ARNs as an attribute in SNS instrumentation case #1989

Closed
pavankrish123 opened this issue Oct 4, 2023 · 1 comment
Closed

Capture ARNs as an attribute in SNS instrumentation case #1989

pavankrish123 opened this issue Oct 4, 2023 · 1 comment

Comments

@pavankrish123
Copy link

pavankrish123 commented Oct 4, 2023

open-telemetry/opentelemetry-js-contrib#1716

Is your feature request related to a problem?
Should we be capturing topic ARNs as messaging.destination instead of name, we loose information about the account, region the topic belongs to by using just the name. This additional information is helpful in locating the topic

Describe the solution you'd like
We already have handle to arn in the boto-core instrumentation extension for SNS. If it makes sense, we should use arn as the value of messaging.destination attribute capture arn

Also considered adding account and region information of the topic to the span attributes, but there are no semantics defined to specify these values

Alternate Solution:

Instead of modifying the existing attribute, account information related to the topic can be included as an additional span attribute. However, it's important to note that there are currently no defined semantics for specifying the value. Something like ....
Suggested attribute: aws.account.id:12343441

cc: @svrnm @noltak3 @yumarg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant