Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-instrumentation-grpc depends on the SDK #2473

Closed
aabmass opened this issue Apr 29, 2024 · 1 comment · Fixed by #2474
Closed

opentelemetry-instrumentation-grpc depends on the SDK #2473

aabmass opened this issue Apr 29, 2024 · 1 comment · Fixed by #2474
Labels
bug Something isn't working gRPC

Comments

@aabmass
Copy link
Member

aabmass commented Apr 29, 2024

opentelemetry-instrumentation-grpc takes a hard dependency on the opentelemetry-sdk package

What is the expected behavior?
Instrumentations should never depend directly on the SDK

What is the actual behavior?
There is a hard dep

Additional context
I haven't investigated why it's there. Hopefully it can be removed trivially.

@aabmass aabmass added the bug Something isn't working label Apr 29, 2024
@aabmass aabmass changed the title gRPC instrumentation depends on the SDK opentelemetry-instrumentation-grpc depends on the SDK Apr 29, 2024
@aabmass aabmass added the gRPC label Apr 29, 2024
@xrmx
Copy link
Contributor

xrmx commented Apr 29, 2024

There's also systems-metrics:

instrumentation/opentelemetry-instrumentation-system-metrics/pyproject.toml:  "opentelemetry-sdk ~= 1.11",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gRPC
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants