From c3abcda23d71851fba2911d720cc75e3d1b693f3 Mon Sep 17 00:00:00 2001 From: David Ashpole Date: Tue, 18 Oct 2022 17:54:22 +0000 Subject: [PATCH] address review comments --- specification/metrics/data-model.md | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/specification/metrics/data-model.md b/specification/metrics/data-model.md index 4962297d88e..74b4e247705 100644 --- a/specification/metrics/data-model.md +++ b/specification/metrics/data-model.md @@ -1469,9 +1469,12 @@ in keys). #### Metric Metadata Prometheus SDK exporters MUST NOT allow duplicate UNIT, HELP, or TYPE -comments for the same metric name to be present on the Prometheus endpoint. -Exporters MUST drop metrics to prevent conflicting TYPE comments, but -SHOULD NOT drop metrics as a result of conflicting UNIT or HELP comments. +comments for the same metric name to be returned in a single scrape of the +Prometheus endpoint. Exporters MUST drop entire metrics to prevent conflicting +TYPE comments, but SHOULD NOT drop metric points as a result of conflicting +UNIT or HELP comments. Instead, all but one of the conflicting UNIT and HELP +comments (but not metric points) SHOULD be dropped. If dropping a comment or +metric points, the exporter SHOULD warn the user through error logging. The Name of an OTLP metric MUST be added as the [OpenMetrics MetricFamily Name](https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#metricfamily),