Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What should happen when you add an invalid span as a link? #1486

Closed
mateuszrzeszutek opened this issue Mar 1, 2021 · 1 comment · Fixed by #1492
Closed

What should happen when you add an invalid span as a link? #1486

mateuszrzeszutek opened this issue Mar 1, 2021 · 1 comment · Fixed by #1492
Labels
area:api Cross language API specification issue area:span-relationships Related to span relationships spec:trace Related to the specification/trace directory

Comments

@mateuszrzeszutek
Copy link
Member

What are you trying to achieve?

What should happen when you add a link to the invalid span, e.g. in Java spanBuilder.addLink(Span.getInvalid())? Right now this situation is not described by the spec, and in Java SDK it turns out that a link to the invalid span is added and can be even exported.

Additional context.
@mateuszrzeszutek mateuszrzeszutek added the spec:trace Related to the specification/trace directory label Mar 1, 2021
@Oberon00 Oberon00 added area:api Cross language API specification issue area:span-relationships Related to span relationships labels Mar 1, 2021
@anuraaga anuraaga mentioned this issue Mar 2, 2021
Merged
@anuraaga
Copy link
Contributor

anuraaga commented Mar 2, 2021

Oh noticed I sent #1492 before getting to this in my notification queue, it would fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:api Cross language API specification issue area:span-relationships Related to span relationships spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore invalid spancontext in addLink anuraaga/opentelemetry-specification
3 participants
@anuraaga @Oberon00 @mateuszrzeszutek