Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider consuming non-supported attribute value types #1509

Open
carlosalberto opened this issue Mar 6, 2021 · 0 comments
Open

Consider consuming non-supported attribute value types #1509

carlosalberto opened this issue Mar 6, 2021 · 0 comments
Labels
area:api Cross language API specification issue spec:trace Related to the specification/trace directory

Comments

@carlosalberto
Copy link
Contributor

For dynamic languages, SetAttribute() MAY end up getting a value of an unsupported type. Current implementations simply ignore the value, but was wondering whether it could be good to do a best-try effort and simply convert the value to string (which is something we did in OpenTracing).

Arguably this will mean having different output, but we haven't frozen the telemetry compatibility section.
@carlosalberto carlosalberto added area:api Cross language API specification issue spec:trace Related to the specification/trace directory labels Mar 6, 2021
@carlosalberto carlosalberto mentioned this issue Mar 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:api Cross language API specification issue spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carlosalberto