Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define OpenTracing error logging translation #1552

Closed
carlosalberto opened this issue Mar 17, 2021 · 0 comments · Fixed by #1563
Closed

Define OpenTracing error logging translation #1552

carlosalberto opened this issue Mar 17, 2021 · 0 comments · Fixed by #1563

Comments

@carlosalberto
Copy link
Contributor

carlosalberto commented Mar 17, 2021

In OpenTracing there was a set of semantic conventions for logging errors, i.e.

try:
  // Failed operation
except OSError as e:
  span.log_kv({
    "event": "error",
    "error.kind": "OSError",
    "error.object": e,
    // etc
  })

We should be mapping this to the existing RecordException(e) operation (or AddEvent() with the proper semantics)

Follow up to #1101

@carlosalberto carlosalberto changed the title Define OT layer error logging translation Define OpenTracing error logging translation Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant