Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on model metric of exporter.export(batch) #2073

Closed
legendecas opened this issue Oct 28, 2021 · 2 comments · Fixed by #2106
Closed

Clarification on model metric of exporter.export(batch) #2073

legendecas opened this issue Oct 28, 2021 · 2 comments · Fixed by #2106
Assignees
Labels
area:sdk Related to the SDK release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:metrics Related to the specification/metrics directory

Comments

@legendecas
Copy link
Member

legendecas commented Oct 28, 2021

What are you trying to achieve?

Export(batch)

Exports a batch of Metrics. Protocol exporters that will implement this function are typically expected to serialize and transmit the data to the destination.
Parameters:
batch - a batch of Metrics. The exact data type of the batch is language specific, typically it is some kind of list.
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#exportbatch

The type name Metrics is not mentioned anywhere else (as far as I can tell, I didn't find anything at https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/datamodel.md) and it is unclear what it contains.

@legendecas legendecas added the spec:metrics Related to the specification/metrics directory label Oct 28, 2021
@reyang reyang added area:sdk Related to the SDK release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs labels Nov 2, 2021
@reyang reyang assigned reyang and unassigned arminru Nov 2, 2021
@reyang
Copy link
Member

reyang commented Nov 2, 2021

It is not specified, but it has to be a stable API. It is "based on" the data model, it should not be based on the Proto generated data types.

@reyang
Copy link
Member

reyang commented Nov 5, 2021

@legendecas based on the discussion from 11/2/2021 Spec SIG Meeting, I've added clarification in #2106. Please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants