Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in source.* and destination.* fieldsets from ECS? #3407

Closed
trask opened this issue Apr 18, 2023 · 3 comments
Closed

Pull in source.* and destination.* fieldsets from ECS? #3407

trask opened this issue Apr 18, 2023 · 3 comments
Assignees
Labels
area:semantic-conventions Related to semantic conventions

Comments

@trask
Copy link
Member

trask commented Apr 18, 2023

It's not clear if these should be pulled in, or if client.* and server.* effectively replace them.

One tangential concern is that currently HTTP messaging semconv has attributes under messaging.source.* and messaging.destination.*, which would conflict if we also adopt the concept from ECS of nested namespaces.

cc @AlexanderWert

@trask
Copy link
Member Author

trask commented Apr 18, 2023

I suspect that source.* and destination.* will be needed, e.g. #3402 (comment)

there are many scenarios where there are equal players (peers) communicating, e.g. nodes in Paxos or any gossip protocol, actors exchanging messages in systems like Akka, etc. How would one decide who is a client or a server in those scenarios?

@Oberon00
Copy link
Member

Oberon00 commented Apr 19, 2023

And note that neither source/destination nor server/client are a conceptual match for host/peer.

So you could make an argument to retain host/peer conventions and add the ECS conventions on top... It's messy.

@AlexanderWert
Copy link
Member

I guess this can be closed because #3402 has been merged?

cc @trask

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions
Projects
None yet
Development

No branches or pull requests

4 participants