From 3e829067dc3c2c8fe7c07e73e9a0726aea1df8ea Mon Sep 17 00:00:00 2001 From: Trask Stalnaker Date: Mon, 28 Mar 2022 21:21:10 -0700 Subject: [PATCH 1/2] Add rpc.system value for Apache Dubbo --- CHANGELOG.md | 2 ++ semantic_conventions/trace/rpc.yaml | 3 +++ 2 files changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9c09183b198..b6effd11422 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -66,6 +66,8 @@ release. ([#2290](https://github.com/open-telemetry/opentelemetry-specification/pull/2290)) - Add semantic conventions for [CloudEvents](https://cloudevents.io). ([#1978](https://github.com/open-telemetry/opentelemetry-specification/pull/1978)) +- Add `rpc.system` value for Apache Dubbo. + ([#9999](https://github.com/open-telemetry/opentelemetry-specification/pull/9999)) ### Compatibility diff --git a/semantic_conventions/trace/rpc.yaml b/semantic_conventions/trace/rpc.yaml index f87b5b29e53..003646e0447 100644 --- a/semantic_conventions/trace/rpc.yaml +++ b/semantic_conventions/trace/rpc.yaml @@ -19,6 +19,9 @@ groups: - id: dotnet_wcf value: 'dotnet_wcf' brief: '.NET WCF' + - id: apache_dubbo + value: 'apache_dubbo' + brief: 'Apache Dubbo' - id: service type: string required: From 3582268431ffc81992a86fbe14d58f0489c7996e Mon Sep 17 00:00:00 2001 From: Trask Stalnaker Date: Mon, 28 Mar 2022 21:46:45 -0700 Subject: [PATCH 2/2] Generate table --- CHANGELOG.md | 2 +- specification/metrics/semantic_conventions/rpc.md | 1 + specification/trace/semantic_conventions/rpc.md | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b6effd11422..39cbfce8924 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -67,7 +67,7 @@ release. - Add semantic conventions for [CloudEvents](https://cloudevents.io). ([#1978](https://github.com/open-telemetry/opentelemetry-specification/pull/1978)) - Add `rpc.system` value for Apache Dubbo. - ([#9999](https://github.com/open-telemetry/opentelemetry-specification/pull/9999)) + ([#2453](https://github.com/open-telemetry/opentelemetry-specification/pull/2453)) ### Compatibility diff --git a/specification/metrics/semantic_conventions/rpc.md b/specification/metrics/semantic_conventions/rpc.md index bcfdab38958..02a45f84a75 100644 --- a/specification/metrics/semantic_conventions/rpc.md +++ b/specification/metrics/semantic_conventions/rpc.md @@ -84,6 +84,7 @@ or not they should be on the server, client or both. | `grpc` | gRPC | | `java_rmi` | Java RMI | | `dotnet_wcf` | .NET WCF | +| `apache_dubbo` | Apache Dubbo | To avoid high cardinality, implementations should prefer the most stable of `net.peer.name` or diff --git a/specification/trace/semantic_conventions/rpc.md b/specification/trace/semantic_conventions/rpc.md index 1f99f6d0050..b1b322aa9e3 100644 --- a/specification/trace/semantic_conventions/rpc.md +++ b/specification/trace/semantic_conventions/rpc.md @@ -80,6 +80,7 @@ Examples of span names: | `grpc` | gRPC | | `java_rmi` | Java RMI | | `dotnet_wcf` | .NET WCF | +| `apache_dubbo` | Apache Dubbo | For client-side spans `net.peer.port` is required if the connection is IP-based and the port is available (it describes the server port they are connecting to).