Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the brief of container.image.id #1236

Open
ChrsMark opened this issue Jul 11, 2024 · 0 comments
Open

Clarify the brief of container.image.id #1236

ChrsMark opened this issue Jul 11, 2024 · 0 comments

Comments

@ChrsMark
Copy link
Member

The container.image.id attribute includes in it's a brief a note about K8s which is not really accurate:

K8s defines a link to the container registry repository with digest "imageID": "registry.azurecr.io/namespace/service/dockerfile@sha256:bdeabd40c3a8a492eaf9e8e44d0ebbb84bac7ee25ac0cf8a7159d25f62555625".

This was explained in a respective Collector's implementation attempt at open-telemetry/opentelemetry-collector-contrib#32314 (comment).

This brief should most probably reflect the following from open-telemetry/opentelemetry-collector-contrib#32314 (comment):

I think one way to proceed is to also use the github.com/distribution/reference package to attempt to parse the output of .imageID from the k8s API response. If it is a canonical reference, then populate the semantic attribute container.image.repo_digests with those values (of which it seems there will only be one from the existing CRI implementations (?)). If it is not, then populate container.image.id.

refs:

/cc @lmolkova @evantorrie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants