Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes about reverse DNS lookup should be centralized #291

Open
Oberon00 opened this issue Aug 29, 2023 · 2 comments
Open

Notes about reverse DNS lookup should be centralized #291

Oberon00 opened this issue Aug 29, 2023 · 2 comments
Assignees
Labels
editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind.

Comments

@Oberon00
Copy link
Member

To avoid redundancy and inconsistencies, Reverse DNS lookup should be centrally adressed in the markdown at one place and then not be mentioned further. I think it is actually not that surprising that we don't want this to happen, so can we just generally say that for all the address and domain attributes, instrumentations SHOULD NOT do a DNS lookup on their own (neither forward nor reverse) but capture the result of the application/libraries lookup or not set the corresponding attribute at all (or in some cases set it to whichever of the set {IP, name} is available). This is not only due to performance but also to avoid reporting inaccurate information for multi-IP hosts by default.

(Related #206)

@Oberon00 Oberon00 added the editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. label Aug 29, 2023
@trask
Copy link
Member

trask commented Aug 31, 2023

I think it is actually not that surprising that we don't want this to happen

I agree, and yet 😅

@Oberon00
Copy link
Member Author

Yeah, the Java APIs unfortunately make this extremely easy to do accidentally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind.
Projects
None yet
Development

No branches or pull requests

4 participants