Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to create semconv-dotnet-approver #355

Closed
lmolkova opened this issue Sep 29, 2023 · 6 comments
Closed

Request to create semconv-dotnet-approver #355

lmolkova opened this issue Sep 29, 2023 · 6 comments
Assignees

Comments

@lmolkova
Copy link
Contributor

I'd like to request creating a new approver group semconv-dotnet-approver and add the following approvers to that group:

This group would be the code-owner for metrics emitted by .NET runtime and libraries which are going (🤞 ) to be added in #283

@lmolkova
Copy link
Contributor Author

@arminru all the folks are now members of OTel, would it be possible to create a group? Thanks!

@arminru
Copy link
Member

arminru commented Oct 13, 2023

@lmolkova I created a group with the initial approvers proposed above:
@open-telemetry/semconv-dotnet-approver.

I was only able to add @noahfalk so far.
@JamesNK and @antonfirsov haven't accepted their invitation to the organization yet.

@antonfirsov
Copy link

Accepted now. (As person who is lazy about clicks, I wish GitHub made it more obvious how to do it.)

@lmolkova
Copy link
Contributor Author

@JamesNK could you please accept the invitation to join @semconv-dotnet-approver group?

@JamesNK
Copy link

JamesNK commented Oct 31, 2023

I didn't get an invite. I just requested to join @open-telemetry/semconv-dotnet-approver

@lmolkova
Copy link
Contributor Author

lmolkova commented Nov 29, 2023

The group is created and everyone has joined - https://github.com/orgs/open-telemetry/teams/semconv-dotnet-approver
Closing the issue.

Thanks @arminru!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants