Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolate tests for staleness markers and up metric tests out of TestEndToEnd #59

Closed
odeke-em opened this issue Jun 22, 2021 · 0 comments
Closed

Isolate tests for staleness markers and up metric tests out of TestEndToEnd #59

odeke-em opened this issue Jun 22, 2021 · 0 comments
Assignees
@odeke-em
Labels
conformance testing PRW conformance testing issue or PR phase1 phase1 tasks prom-receiver Prometheus receiver tasks

Comments

@odeke-em
Copy link
Member

We currently have some difficulty with the OpenTelemetry Collector Prometheus receiver's TestEndToEnd because that code was written in 2019 and didn't account for staleness markers (PR for open-telemetry/opentelemetry-collector#3423) nor the up metric per PR open-telemetry/opentelemetry-collector#3116

@Aneurysm9 suggested that perhaps we can move out assertions on the Up metric and the staleness markers out of that test and into their own tests. /cc @alolita
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odeke-em odeke-em

Labels
conformance testing PRW conformance testing issue or PR phase1 phase1 tasks prom-receiver Prometheus receiver tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alolita @odeke-em