Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH Request] Codecov token not found in Credentials #1262

Closed
MaxFrank13 opened this issue Sep 20, 2024 · 5 comments
Closed

[GH Request] Codecov token not found in Credentials #1262

MaxFrank13 opened this issue Sep 20, 2024 · 5 comments
Assignees
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.

Comments

@MaxFrank13
Copy link
Member

Repository

credentials

Urgency

Medium (< 2 weeks)

Requested Change

When running code coverage in CI for the credentials repo, the workflow throws an error because it is unable to find a Codecov token (source). We'd like to have a token added to the repository (docs).

Reasoning

We want this change to be made so that code coverage can run in CI.

@MaxFrank13 MaxFrank13 added the github-request Request for change to access level or settings in the openedx GitHub organization. label Sep 20, 2024
Copy link

Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer.

@bmtcril bmtcril self-assigned this Sep 20, 2024
@bmtcril
Copy link
Contributor

bmtcril commented Sep 20, 2024

@MaxFrank13 there was a duplicate codecov token in the repo, which I've removed per the instructions here: https://openedx.atlassian.net/wiki/spaces/COMM/pages/3438280709/Adding+Codecov . I think tests were running a second time unnecessarily just for Codecov, so I'm removing that and testing things here: https://github.com/openedx/credentials/actions/runs/10962121735/job/30440625824?pr=2588 if you'd like to follow along.

@bmtcril
Copy link
Contributor

bmtcril commented Sep 20, 2024

Ok this should be set if anyone wants to review and merge it:

info - 2024-09-20 15:46:49,142 -- Found 1 coverage files to report
info - 2024-09-20 15:46:49,142 -- > /home/runner/work/credentials/credentials/coverage.xml
info - 2024-09-20 15:46:49,869 -- Your upload is now processing. When finished, results will be available at: https://app.codecov.io/github/openedx/credentials/commit/9540d2e586c6b1ffe8eeff1dd66923019d3ddf77
info - 2024-09-20 15:46:50,183 -- Process Upload complete

@bmtcril
Copy link
Contributor

bmtcril commented Sep 20, 2024

Looks like this is doing the right thing, now so I'm going to close it. LMK if you run into any issues.

@bmtcril bmtcril closed this as completed Sep 20, 2024
@MaxFrank13
Copy link
Member Author

Thanks @bmtcril!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.
Projects
Status: Done
Development

No branches or pull requests

2 participants