Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Owner recover phrase creates different account #3584

Closed
NitroMoo opened this issue Nov 23, 2016 · 15 comments
Closed

Owner recover phrase creates different account #3584

NitroMoo opened this issue Nov 23, 2016 · 15 comments
Assignees
Labels
F1-security 🛡 The client fails to follow expected, security-sensitive, behaviour.

Comments

@NitroMoo
Copy link

When you create the new account with "new account manually" option, it shows the recovery phrase in the end.

However, you cannot recreate this initial account with this phrase, it will create a different account with the different address, which then could be recovered with that phrase.

@gavofyork
Copy link
Contributor

gavofyork commented Nov 23, 2016

just tried this and works perfectly for me. are you sure you typed the phrase correctly? could you include the version of parity that you are running (and were you running a different version when you first generated the account?)

@gavofyork gavofyork added the Z9-invalid 👮‍♀️ Issue is invalid. Closer should comment why. label Nov 23, 2016
@NitroMoo
Copy link
Author

I am pretty sure i am typing it correctly, i've tried it over 15 times already with different methods - copy pasting whole phrase, pasting word by word, typing manually.

I am using the Parity//v1.4.4, synced by using --warp and --pruning fast

@NitroMoo
Copy link
Author

NitroMoo commented Nov 24, 2016

I broke it down with 3 screenshots, can you please take a look and see if i am doing something wrong?
(a test empty account with 0 balance)

1.https://i.gyazo.com/6a086691c6cee66bcbcb8155a7a5c7fe.png
2. https://i.gyazo.com/71b78b55f904f2616fd4584f105f04d2.png
3. https://i.gyazo.com/c7936ee6140c4ef0e46910b51956af7f.png

@NitroMoo
Copy link
Author

I am pretty confident that its not a human error, i can recover accounts that were created via "recover from phrase" by re-typing same phrase, but still cant recover any "new" accounts created manually.

@gavofyork gavofyork added Z0-unconfirmed 🤔 Issue might be valid, but it’s not yet known. F1-security 🛡 The client fails to follow expected, security-sensitive, behaviour. M7-ui and removed Z9-invalid 👮‍♀️ Issue is invalid. Closer should comment why. Z0-unconfirmed 🤔 Issue might be valid, but it’s not yet known. labels Nov 24, 2016
@gavofyork
Copy link
Contributor

reopening after @3esmit confirms there's an issue lurking somewhere.

@gavofyork gavofyork reopened this Nov 24, 2016
@gavofyork
Copy link
Contributor

what platform are you running on?

@tomusdrw
Copy link
Collaborator

Reproduced on Windows, culprit:

{
"jsonrpc":"2.0",
"id":1,
  "method": "parity_generateSecretPhrase",
  "params": []
}
{
    "jsonrpc": "2.0",
    "result": "natural\r certified\r cupid\r merely\r hump\r lip\r psych\r devices\r jane\r steak\r asia\r reports\r",
    "id": 1
}

@NitroMoo
Copy link
Author

I was also using Win10

@gavofyork
Copy link
Contributor

thanks for reporting - there will be fix allowing you to recover the original account from the phrase in 1.4.5.

@NitroMoo
Copy link
Author

Nice!
Quick questions:

  1. Are the current accounts, created in 1.4.4, any less secure besides the fact that the phrase wont work on them?
  2. Are my phrases for all my accounts that i wrote down completely useless and not linked with these accounts in any way?
  3. If SHA-3 #2 is true, then do these accounts have any phrases linked to them at all?

Thank you for your time

@gavofyork
Copy link
Contributor

  1. they're no less secure (only difference is that the \t characters were not stripped from the end of the words).
  2. your phrases can all be used to regenerate the accounts that you are using as you would expect
  3. n/a

@NitroMoo
Copy link
Author

NitroMoo commented Nov 24, 2016

Nice.

Thanks for the explanation

@tomusdrw
Copy link
Collaborator

Fixed with #3614 and #3615

@brucelkp
Copy link

brucelkp commented Sep 6, 2017

my hardisk crashed after reinstalling windows unable to restore back my account with the phase key; it will create one with another address; any other information i need other then the phrase key?

@5chdn
Copy link
Contributor

5chdn commented Sep 6, 2017

@brucelkp which parity version did you use to create that account? and which operating system did you use?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F1-security 🛡 The client fails to follow expected, security-sensitive, behaviour.
Projects
None yet
Development

No branches or pull requests

5 participants