From a5716cacc4a254e2033fa12c7ae33bfccf29e642 Mon Sep 17 00:00:00 2001
From: nagyad <joevagyok@gmail.com>
Date: Tue, 8 Jan 2019 15:24:56 +0100
Subject: [PATCH] OPENEUROPA-1500: Add review improvements.

---
 .../oe_webtools_analytics.permissions.yml         |  2 +-
 .../src/Form/WebtoolsAnalyticsSettingsForm.php    | 15 ++++++++-------
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/modules/oe_webtools_analytics/oe_webtools_analytics.permissions.yml b/modules/oe_webtools_analytics/oe_webtools_analytics.permissions.yml
index 3be57b9f..18eb4719 100644
--- a/modules/oe_webtools_analytics/oe_webtools_analytics.permissions.yml
+++ b/modules/oe_webtools_analytics/oe_webtools_analytics.permissions.yml
@@ -1,3 +1,3 @@
 administer webtools analytics:
   title: 'Administer Webtools Analytics'
-  restrict access: false
\ No newline at end of file
+  restrict access: false
diff --git a/modules/oe_webtools_analytics/src/Form/WebtoolsAnalyticsSettingsForm.php b/modules/oe_webtools_analytics/src/Form/WebtoolsAnalyticsSettingsForm.php
index 02214d9e..bd164bc0 100644
--- a/modules/oe_webtools_analytics/src/Form/WebtoolsAnalyticsSettingsForm.php
+++ b/modules/oe_webtools_analytics/src/Form/WebtoolsAnalyticsSettingsForm.php
@@ -24,13 +24,6 @@ public function getFormId() {
     return 'oe_webtools_analytics_settings';
   }
 
-  /**
-   * {@inheritdoc}
-   */
-  protected function getEditableConfigNames() {
-    return ['oe_webtools_analytics.settings'];
-  }
-
   /**
    * {@inheritdoc}
    */
@@ -53,6 +46,7 @@ public function buildForm(array $form, FormStateInterface $form_state) {
       '#default_value' => $this->config(static::CONFIGNAME)->get('instance'),
       '#description' => $this->t('The server instance. e.g. testing, ec.europa.eu or europa.eu.'),
     ];
+
     return parent::buildForm($form, $form_state);
   }
 
@@ -68,4 +62,11 @@ public function submitForm(array &$form, FormStateInterface $form_state) {
     parent::submitForm($form, $form_state);
   }
 
+  /**
+   * {@inheritdoc}
+   */
+  protected function getEditableConfigNames() {
+    return ['oe_webtools_analytics.settings'];
+  }
+
 }