Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the Service Health Check Mechanism #911

Closed
cubxxw opened this issue Aug 22, 2023 — with Slack · 1 comment · Fixed by #825
Closed

Enhance the Service Health Check Mechanism #911

cubxxw opened this issue Aug 22, 2023 — with Slack · 1 comment · Fixed by #825
Assignees
Labels
feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

Copy link
Contributor

cubxxw commented Aug 22, 2023

Enhance the Service Health Check Mechanism

Description:

In our current mechanism to check the health status of various services (MySQL, MongoDB, Minio, etc.), there's a possibility to enhance its maintainability and flexibility:

Current Behavior:

  1. The configuration file's path is hardcoded.
  2. Each service's health check status is verified with individual code blocks, leading to redundancy.
  3. Error handling can be streamlined for better clarity.

Proposed Changes:

  1. Implement command-line flags to allow users to specify the configuration file's path.
  2. Utilize a unified function array structure to iterate through all checks, thus reducing redundancy.
  3. Refactor error handling to make the code clearer and more concise.
@cubxxw cubxxw added the feature Categorizes issue or PR as related to a new feature. label Aug 22, 2023 — with Slack
@cubxxw cubxxw added this to the v3.1 milestone Aug 22, 2023 — with Slack
@cubxxw cubxxw self-assigned this Aug 22, 2023
@cubxxw
Copy link
Contributor Author

cubxxw commented Aug 23, 2023

Link, This issue has been resolved #825

@cubxxw cubxxw closed this as completed Aug 23, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Categorizes issue or PR as related to a new feature.
Projects
None yet
1 participant