From 5c1fe29961c1d9a6fe8550f4460591341e66cfa1 Mon Sep 17 00:00:00 2001 From: "opensearch-trigger-bot[bot]" <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Date: Tue, 7 Mar 2023 08:56:26 -0800 Subject: [PATCH] [BUG][TSVB] Fix serial diff agg link (#3503) (#3505) Doc link was invalid and causing an undefined error. This prevented the UI from mounting properly. Issue(s) resolved: * https://github.com/opensearch-project/OpenSearch-Dashboards/issues/3498 * https://github.com/opensearch-project/OpenSearch-Dashboards/issues/3327 Signed-off-by: Kawika Avilla (cherry picked from commit 69bcbfeea9bb345364e47f048cd5bcfe64c9c242) Signed-off-by: github-actions[bot] # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] Co-authored-by: Josh Romero --- .../public/application/components/aggs/serial_diff.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/plugins/vis_type_timeseries/public/application/components/aggs/serial_diff.js b/src/plugins/vis_type_timeseries/public/application/components/aggs/serial_diff.js index 989e2cec922..a31a4b79a8d 100644 --- a/src/plugins/vis_type_timeseries/public/application/components/aggs/serial_diff.js +++ b/src/plugins/vis_type_timeseries/public/application/components/aggs/serial_diff.js @@ -59,7 +59,8 @@ export const SerialDiffAgg = (props) => { const handleNumberChange = createNumberHandler(handleChange); const htmlId = htmlIdGenerator(); - const docLinks = useOpenSearchDashboards().services.docLinks; + const serialDiffDoc = useOpenSearchDashboards().services.docLinks?.links.opensearch.aggregations + .pipeline.serial_diff; return ( { id="visTypeTimeseries.serialDiff.lagLabel" defaultMessage="Lag" description={`'Lag' refers to the parameter name of the serial diff translation - ${docLinks.services.links.opensearch.aggregations.pipeline.serial_diff}. + ${serialDiffDoc}. This should only be translated if there is a reasaonable word explaining what that parameter does.`} /> }