From 7c97977bd7cefb215eaaa614ca318cb53c252f9b Mon Sep 17 00:00:00 2001
From: "opensearch-trigger-bot[bot]"
 <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Date: Mon, 7 Nov 2022 16:23:12 -0800
Subject: [PATCH] [MD] Add explicit no spellcheck on password fields (#2818)
 (#2821)

Signed-off-by: Kristen Tian <tyarong@amazon.com>

Signed-off-by: Kristen Tian <tyarong@amazon.com>
(cherry picked from commit fe4b8607b248fa379ce49ac46f2879b93771955c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
---
 .../__snapshots__/create_data_source_wizard.test.tsx.snap   | 4 ++++
 .../__snapshots__/create_data_source_form.test.tsx.snap     | 6 ++++++
 .../components/create_form/create_data_source_form.tsx      | 1 +
 .../__snapshots__/edit_data_source.test.tsx.snap            | 2 ++
 .../__snapshots__/edit_data_source_form.test.tsx.snap       | 2 ++
 .../components/edit_form/edit_data_source_form.tsx          | 1 +
 .../__snapshots__/update_password_modal.test.tsx.snap       | 6 ++++++
 .../update_password_modal/update_password_modal.tsx         | 2 ++
 8 files changed, 24 insertions(+)

diff --git a/src/plugins/data_source_management/public/components/create_data_source_wizard/__snapshots__/create_data_source_wizard.test.tsx.snap b/src/plugins/data_source_management/public/components/create_data_source_wizard/__snapshots__/create_data_source_wizard.test.tsx.snap
index b4331e26f79..c7e3152fca9 100644
--- a/src/plugins/data_source_management/public/components/create_data_source_wizard/__snapshots__/create_data_source_wizard.test.tsx.snap
+++ b/src/plugins/data_source_management/public/components/create_data_source_wizard/__snapshots__/create_data_source_wizard.test.tsx.snap
@@ -775,6 +775,7 @@ exports[`Datasource Management: Create Datasource Wizard case1: should load reso
                         onChange={[Function]}
                         onFocus={[Function]}
                         placeholder="Password to connect to data source"
+                        spellCheck={false}
                         type="dual"
                         value=""
                       >
@@ -811,6 +812,7 @@ exports[`Datasource Management: Create Datasource Wizard case1: should load reso
                                   onChange={[Function]}
                                   onFocus={[Function]}
                                   placeholder="Password to connect to data source"
+                                  spellCheck={false}
                                   type="password"
                                   value=""
                                 />
@@ -1749,6 +1751,7 @@ exports[`Datasource Management: Create Datasource Wizard case2: should fail to l
                         onChange={[Function]}
                         onFocus={[Function]}
                         placeholder="Password to connect to data source"
+                        spellCheck={false}
                         type="dual"
                         value=""
                       >
@@ -1785,6 +1788,7 @@ exports[`Datasource Management: Create Datasource Wizard case2: should fail to l
                                   onChange={[Function]}
                                   onFocus={[Function]}
                                   placeholder="Password to connect to data source"
+                                  spellCheck={false}
                                   type="password"
                                   value=""
                                 />
diff --git a/src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/__snapshots__/create_data_source_form.test.tsx.snap b/src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/__snapshots__/create_data_source_form.test.tsx.snap
index fcd197cc082..0e8dc0a57a6 100644
--- a/src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/__snapshots__/create_data_source_form.test.tsx.snap
+++ b/src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/__snapshots__/create_data_source_form.test.tsx.snap
@@ -1537,6 +1537,7 @@ exports[`Datasource Management: Create Datasource form should create data source
                       onChange={[Function]}
                       onFocus={[Function]}
                       placeholder="Password to connect to data source"
+                      spellCheck={false}
                       type="dual"
                       value="test123"
                     >
@@ -1573,6 +1574,7 @@ exports[`Datasource Management: Create Datasource form should create data source
                                 onChange={[Function]}
                                 onFocus={[Function]}
                                 placeholder="Password to connect to data source"
+                                spellCheck={false}
                                 type="password"
                                 value="test123"
                               />
@@ -2469,6 +2471,7 @@ exports[`Datasource Management: Create Datasource form should render normally 1`
                       onChange={[Function]}
                       onFocus={[Function]}
                       placeholder="Password to connect to data source"
+                      spellCheck={false}
                       type="dual"
                       value=""
                     >
@@ -2505,6 +2508,7 @@ exports[`Datasource Management: Create Datasource form should render normally 1`
                                 onChange={[Function]}
                                 onFocus={[Function]}
                                 placeholder="Password to connect to data source"
+                                spellCheck={false}
                                 type="password"
                                 value=""
                               />
@@ -3418,6 +3422,7 @@ exports[`Datasource Management: Create Datasource form should throw validation e
                       onChange={[Function]}
                       onFocus={[Function]}
                       placeholder="Password to connect to data source"
+                      spellCheck={false}
                       type="dual"
                       value="test123"
                     >
@@ -3454,6 +3459,7 @@ exports[`Datasource Management: Create Datasource form should throw validation e
                                 onChange={[Function]}
                                 onFocus={[Function]}
                                 placeholder="Password to connect to data source"
+                                spellCheck={false}
                                 type="password"
                                 value="test123"
                               />
diff --git a/src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx b/src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx
index 429790231a5..b159065822d 100644
--- a/src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx
+++ b/src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx
@@ -276,6 +276,7 @@ export class CreateDataSourceForm extends React.Component<
             value={this.state.auth.credentials.password || ''}
             onChange={this.onChangePassword}
             onBlur={this.validatePassword}
+            spellCheck={false}
             data-test-subj="createDataSourceFormPasswordField"
           />
         </EuiFormRow>
diff --git a/src/plugins/data_source_management/public/components/edit_data_source/__snapshots__/edit_data_source.test.tsx.snap b/src/plugins/data_source_management/public/components/edit_data_source/__snapshots__/edit_data_source.test.tsx.snap
index a3d004457a7..2858167a08c 100644
--- a/src/plugins/data_source_management/public/components/edit_data_source/__snapshots__/edit_data_source.test.tsx.snap
+++ b/src/plugins/data_source_management/public/components/edit_data_source/__snapshots__/edit_data_source.test.tsx.snap
@@ -1018,6 +1018,7 @@ exports[`Datasource Management: Edit Datasource Wizard should load resources suc
                                           onBlur={[Function]}
                                           onChange={[Function]}
                                           placeholder="Password to connect to data source"
+                                          spellCheck={false}
                                           type="dual"
                                           value="********"
                                         >
@@ -1054,6 +1055,7 @@ exports[`Datasource Management: Edit Datasource Wizard should load resources suc
                                                     onBlur={[Function]}
                                                     onChange={[Function]}
                                                     placeholder="Password to connect to data source"
+                                                    spellCheck={false}
                                                     type="password"
                                                     value="********"
                                                   />
diff --git a/src/plugins/data_source_management/public/components/edit_data_source/components/edit_form/__snapshots__/edit_data_source_form.test.tsx.snap b/src/plugins/data_source_management/public/components/edit_data_source/components/edit_form/__snapshots__/edit_data_source_form.test.tsx.snap
index 1ce16bf131c..84c105d68ee 100644
--- a/src/plugins/data_source_management/public/components/edit_data_source/components/edit_form/__snapshots__/edit_data_source_form.test.tsx.snap
+++ b/src/plugins/data_source_management/public/components/edit_data_source/components/edit_form/__snapshots__/edit_data_source_form.test.tsx.snap
@@ -965,6 +965,7 @@ exports[`Datasource Management: Edit Datasource Form Case 1: With Username & Pas
                                         onBlur={[Function]}
                                         onChange={[Function]}
                                         placeholder="Password to connect to data source"
+                                        spellCheck={false}
                                         type="dual"
                                         value="********"
                                       >
@@ -1001,6 +1002,7 @@ exports[`Datasource Management: Edit Datasource Form Case 1: With Username & Pas
                                                   onBlur={[Function]}
                                                   onChange={[Function]}
                                                   placeholder="Password to connect to data source"
+                                                  spellCheck={false}
                                                   type="password"
                                                   value="********"
                                                 />
diff --git a/src/plugins/data_source_management/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx b/src/plugins/data_source_management/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx
index bda8709cf50..46c91ad540c 100644
--- a/src/plugins/data_source_management/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx
+++ b/src/plugins/data_source_management/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx
@@ -585,6 +585,7 @@ export class EditDataSourceForm extends React.Component<EditDataSourceProps, Edi
                     : this.state.auth.credentials.password
                 }
                 isInvalid={!!this.state.formErrorsByField.createCredential?.password?.length}
+                spellCheck={false}
                 onChange={this.onChangePassword}
                 onBlur={this.validatePassword}
                 disabled={this.props.existingDataSource.auth.type !== AuthType.NoAuth}
diff --git a/src/plugins/data_source_management/public/components/edit_data_source/components/update_password_modal/__snapshots__/update_password_modal.test.tsx.snap b/src/plugins/data_source_management/public/components/edit_data_source/components/update_password_modal/__snapshots__/update_password_modal.test.tsx.snap
index ef19172398e..7c5de9b6ba2 100644
--- a/src/plugins/data_source_management/public/components/edit_data_source/components/update_password_modal/__snapshots__/update_password_modal.test.tsx.snap
+++ b/src/plugins/data_source_management/public/components/edit_data_source/components/update_password_modal/__snapshots__/update_password_modal.test.tsx.snap
@@ -142,6 +142,7 @@ exports[`Datasource Management: Update Stored Password Modal should render norma
                                       id="generated-id"
                                       name="updatedPassword"
                                       placeholder="Updated password"
+                                      spellcheck="false"
                                       type="password"
                                       value=""
                                     />
@@ -205,6 +206,7 @@ exports[`Datasource Management: Update Stored Password Modal should render norma
                                       id="generated-id"
                                       name="confirmUpdatedPassword"
                                       placeholder="Confirm Updated password"
+                                      spellcheck="false"
                                       type="password"
                                       value=""
                                     />
@@ -529,6 +531,7 @@ exports[`Datasource Management: Update Stored Password Modal should render norma
                                       onChange={[Function]}
                                       onFocus={[Function]}
                                       placeholder="Updated password"
+                                      spellCheck={false}
                                       type="dual"
                                       value=""
                                     >
@@ -566,6 +569,7 @@ exports[`Datasource Management: Update Stored Password Modal should render norma
                                                 onChange={[Function]}
                                                 onFocus={[Function]}
                                                 placeholder="Updated password"
+                                                spellCheck={false}
                                                 type="password"
                                                 value=""
                                               />
@@ -691,6 +695,7 @@ exports[`Datasource Management: Update Stored Password Modal should render norma
                                       onChange={[Function]}
                                       onFocus={[Function]}
                                       placeholder="Confirm Updated password"
+                                      spellCheck={false}
                                       type="dual"
                                       value=""
                                     >
@@ -728,6 +733,7 @@ exports[`Datasource Management: Update Stored Password Modal should render norma
                                                 onChange={[Function]}
                                                 onFocus={[Function]}
                                                 placeholder="Confirm Updated password"
+                                                spellCheck={false}
                                                 type="password"
                                                 value=""
                                               />
diff --git a/src/plugins/data_source_management/public/components/edit_data_source/components/update_password_modal/update_password_modal.tsx b/src/plugins/data_source_management/public/components/edit_data_source/components/update_password_modal/update_password_modal.tsx
index 95ca0abe6e9..693a8a84234 100644
--- a/src/plugins/data_source_management/public/components/edit_data_source/components/update_password_modal/update_password_modal.tsx
+++ b/src/plugins/data_source_management/public/components/edit_data_source/components/update_password_modal/update_password_modal.tsx
@@ -125,6 +125,7 @@ export const UpdatePasswordModal = ({
                 type={'dual'}
                 value={newPassword}
                 isInvalid={!isNewPasswordValid}
+                spellCheck={false}
                 onChange={(e) => setNewPassword(e.target.value)}
                 onBlur={validateNewPassword}
               />
@@ -149,6 +150,7 @@ export const UpdatePasswordModal = ({
                 type={'dual'}
                 value={confirmNewPassword}
                 isInvalid={!!isConfirmNewPasswordValid.length}
+                spellCheck={false}
                 onChange={(e) => setConfirmNewPassword(e.target.value)}
                 onBlur={validateConfirmNewPassword}
               />