Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Index patterns should have titles? #2649

Open
kavilla opened this issue Oct 21, 2022 · 2 comments
Open

[FEATURE] Index patterns should have titles? #2649

kavilla opened this issue Oct 21, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@kavilla
Copy link
Member

kavilla commented Oct 21, 2022

Should index patterns have titles themselves? Underneath the hood, index-patterns utilize the title to be the index pattern but should we have a unique title?

@kavilla kavilla added the enhancement New feature or request label Oct 21, 2022
@joshuarrrr
Copy link
Member

In general, the purpose/customer benefit of the saved object title property is that it allows users to create a human-meaningful reference to that object. For simple index patterns, the pattern itself may be a good default title, if the underlying indices also have semantically meaningful names. But for more complicated patterns or distinguishing between two very similar patterns, a separate title property might be useful.

@joshuarrrr
Copy link
Member

@AMoo-Miki I'm afraid it's as you feared. Here's where we actually set the pattern into the title property on save: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/create_index_pattern_wizard.tsx#L200

What's worse, there is not pattern property - the pattern just is the title as far as the SavedObject is concerned: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/data/server/saved_objects/index_patterns.ts#L62-L63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants