Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lint check to fail on unused imports #6249

Open
tianleh opened this issue Mar 22, 2024 · 3 comments
Open

Update lint check to fail on unused imports #6249

tianleh opened this issue Mar 22, 2024 · 3 comments
Assignees
@tianleh

Comments

@tianleh
Copy link
Member

tianleh commented Mar 22, 2024

Inspired by this PR https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6238/files#diff-64b1602fad5390a43ba7818ccf81da02b96edf4870abe38db28492a955dda911L9 , we notice that lint check is not failing for unused imports. The proposal is to update lint check to fail on unused imports so that during PR review, we are able to see a failed workflow if it happens.
@tianleh tianleh mentioned this issue Mar 22, 2024
Merged
7 tasks
@cwperks
Copy link
Member

cwperks commented Mar 25, 2024

I think this rule is being applied on .js files, but is not being applied on other extensions.

This file has a rule for no-unused_vars, but its only applicable to .js files.

@AMoo-Miki
Copy link
Collaborator

Either of you interested in PRing the required change?

@tianleh
Copy link
Member Author

tianleh commented Mar 25, 2024

Either of you interested in PRing the required change?

I will make the change. Just assigned to myself.

@tianleh tianleh self-assigned this Mar 25, 2024
@cwperks cwperks mentioned this issue Mar 26, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tianleh tianleh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AMoo-Miki @cwperks @tianleh