Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question?] G1GC Custom Settings #11649

Closed
andrross opened this issue Dec 19, 2023 · 1 comment · Fixed by #11651
Closed

[Question?] G1GC Custom Settings #11649

andrross opened this issue Dec 19, 2023 · 1 comment · Fixed by #11651
Labels
enhancement Enhancement or improvement to existing feature or request Indexing:Performance Search:Performance v2.12.0 Issues and PRs related to version 2.12.0 v3.0.0 Issues and PRs related to version 3.0.0

Comments

@andrross
Copy link
Member

andrross commented Dec 19, 2023

Is your feature request related to a problem? Please describe

Does anyone have the history as to why these custom G1GC tunings were configured?

11-:-XX:G1ReservePercent=25
11-:-XX:InitiatingHeapOccupancyPercent=30

I believe the defaults are G1ReservePercent=5 and InitiatingHeapOccupancyPercent=45. I'm personally a fan of not overriding the defaults unless there is good evidence this is better in the general case and we continually re-evaluate these settings with each JDK update. I traced this change back to #2916 where we had inadvertently changed the default GC from G1GC back to CMS when we changed OpenSearch 1.x to use JDK11 LTS. This change introduced G1GC by default for all JDKs 11 and newer, but I don't see any discussion as to why these two settings were applied.

@reta Tagging you since you were involved in this change.

Describe the solution you'd like

I'm looking for the justification for using these non-default settings. (Also looks like there is an incorrect comment in the jvm.options file that I will clean up as well)

Related component

Search:Performance

Describe alternatives you've considered

No response

Additional context

No response

@andrross andrross added enhancement Enhancement or improvement to existing feature or request untriaged labels Dec 19, 2023
@reta
Copy link
Collaborator

reta commented Dec 19, 2023

@andrross traced it to elastic/elasticsearch#46169

@reta reta added v3.0.0 Issues and PRs related to version 3.0.0 v2.12.0 Issues and PRs related to version 2.12.0 and removed untriaged labels Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Indexing:Performance Search:Performance v2.12.0 Issues and PRs related to version 2.12.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
Status: Planned work items
Development

Successfully merging a pull request may close this issue.

2 participants