Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Generic Numeric Type Converters for Numeric Field Data #14657

Closed
sarthakaggarwal97 opened this issue Jul 5, 2024 · 1 comment · Fixed by #15442
Closed
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing Search:Aggregations

Comments

@sarthakaggarwal97
Copy link
Contributor

sarthakaggarwal97 commented Jul 5, 2024

Is your feature request related to a problem? Please describe

With an ongoing introduction of Star Tree (Composite Field), there was a requirement to convert the sortable long value of a field to an original numeric type value in order to perform aggregations via star tree.

Currently, we picked up different numeric conversions for different numeric types to incorporate for star tree. This is prone to inconsistent results in cases where the type conversion implementation changes in the original aggregation flow.

Describe the solution you'd like

A generic utility to perform numeric type conversion across OpenSearch. This will become a one-stop utility for numeric conversions.

Related component

Indexing

@sarthakaggarwal97 sarthakaggarwal97 added enhancement Enhancement or improvement to existing feature or request untriaged labels Jul 5, 2024
@github-actions github-actions bot added the Indexing Indexing, Bulk Indexing and anything related to indexing label Jul 5, 2024
@mgodwan
Copy link
Member

mgodwan commented Jul 5, 2024

A generic utility to perform numeric type conversion across OpenSearch. This will become a one-stop utility for numeric conversions.

Won't using this utility still be an opt-in. Can we bake something to achieve this within the contract for these mappers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing Search:Aggregations
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants