Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Transforming Metric Value to Aggregated Value Type during Star Tree Merges #15275

Closed
sarthakaggarwal97 opened this issue Aug 16, 2024 · 0 comments · Fixed by #15274
Closed
Labels

Comments

@sarthakaggarwal97
Copy link
Contributor

Describe the bug

Whenever we were reading the star tree documents from the segment during merges, we were transforming the segment metric doc value to its original field type. Instead, it should be converted to aggregator value type since before indexing doc values, the metric type is of the aggregator value type.

For Example.

If there is a Half Float Metric Field, with the SUM metric (double type). The Half Float Metric field is converted to double during aggregation and indexed as "double". During reads, the metric should be converted from sortable long back to double only for accurate aggregations.

Related component

Indexing:Performance

To Reproduce

Merges during star tree will break for any other data type than double

Expected behavior

The metric should be converted to aggregated value type during merges.

Additional Details

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants