Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Construct StarTreeMetadata prior to Writes #15467

Closed
sarthakaggarwal97 opened this issue Aug 28, 2024 · 2 comments
Closed

[BUG] Construct StarTreeMetadata prior to Writes #15467

sarthakaggarwal97 opened this issue Aug 28, 2024 · 2 comments
Labels

Comments

@sarthakaggarwal97
Copy link
Contributor

Describe the bug

Currently, we rely on a bunch of parameters to construct the star tree metadata. Instead, to improve readability, we can construct the StarTreeMetadata, and use getters to write it

Related component

Indexing:Performance

To Reproduce

N/A

Expected behavior

Construct StarTreeMetadata in BaseStarTreeBuilder to improve readability

Additional Details

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@vikasvb90
Copy link
Contributor

vikasvb90 commented Sep 2, 2024

[Indexing Triage - 09/02]
Thanks @sarthakaggarwal97 for raising this! Can you please add more details around what you mean by improving the readability and how this falls under the category of a bug?
It would also be good if you can add some code pointers as well for better understanding of the issue.

Can you please also add respective tags for the release you are targeting this change in?

@bharath-techie
Copy link
Contributor

Marking this as closed , @sarthakaggarwal97 can provide more details as requested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants