Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Aggregate phase_took results for cross cluster search #15961

Open
dzane17 opened this issue Sep 17, 2024 · 1 comment
Open

[BUG] Aggregate phase_took results for cross cluster search #15961

dzane17 opened this issue Sep 17, 2024 · 1 comment
Assignees
Labels
bug Something isn't working Search Search query, autocomplete ...etc

Comments

@dzane17
Copy link
Contributor

dzane17 commented Sep 17, 2024

Describe the bug

For CCS requests, the phase_took response is retrieved from a single remote cluster SearchResponse. This is incorrect when there are 2+ remote clusters.

See getMergedResponse function

Related component

Search

To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

getMergedResponse should aggregate phase_took data from all remote cluster SearchResponse objects. We can use sum, max, or average to maintain the response structure. I initially thought sum is best but this will break the expectation of total phase_took times roughly equalling took time.

Additional Details

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@dzane17 dzane17 added bug Something isn't working untriaged labels Sep 17, 2024
@github-actions github-actions bot added the Search Search query, autocomplete ...etc label Sep 17, 2024
@dzane17 dzane17 self-assigned this Sep 17, 2024
@getsaurabh02
Copy link
Member

Thanks @dzane17 for opening this issue. We hope you will take this forward with the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Search Search query, autocomplete ...etc
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants