Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Nebula Gradle info plugin upgrade errors #3002

Closed
VachaShah opened this issue Apr 20, 2022 · 9 comments
Closed

[BUG] Nebula Gradle info plugin upgrade errors #3002

VachaShah opened this issue Apr 20, 2022 · 9 comments
Assignees
Labels
bug Something isn't working Build Libraries & Interfaces Priority-Medium v3.0.0 Issues and PRs related to version 3.0.0

Comments

@VachaShah
Copy link
Collaborator

Describe the bug
After upgrading the nebula gradle info plugin (#2831), when applying opensearch.build plugin in gradle, it is causing the below error:

A problem occurred evaluating root project 'bwc-test'.
> Failed to apply plugin 'nebula.info-basic'.
   > Cannot obtain value from provider of system property 'user.name' at configuration time.
     Use a provider returned by 'forUseAtConfigurationTime()' instead.

Security plugin faced this issue when moving to 2.0 for bwc tests - #2987

To Reproduce
Steps to reproduce the behavior:
Added in #2987

Expected behavior
The upgrade does not cause errors.

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@VachaShah VachaShah added bug Something isn't working untriaged labels Apr 20, 2022
@VachaShah VachaShah changed the title [BUG] Nebula Gradle info plugin errors [BUG] Nebula Gradle info plugin upgrade errors Apr 20, 2022
@Poojita-Raj Poojita-Raj removed their assignment Apr 26, 2022
@andrross
Copy link
Member

andrross commented May 4, 2022

@VachaShah I see that we are using the upgraded version on main currently. Does this mean that plugins are currently broken on main (3.0) because of this?

@VachaShah
Copy link
Collaborator Author

@VachaShah I see that we are using the upgraded version on main currently. Does this mean that plugins are currently broken on main (3.0) because of this?

Yes I created the issue so that it can fixed on main, we can revert it as well. @Poojita-Raj were you able to see what the issue was?

@saratvemulapalli
Copy link
Member

Another PR related to the same package: #3250

@owaiskazi19
Copy link
Member

owaiskazi19 commented May 16, 2022

Hi @cliu123! Coming from #2987. I tried to change the gradle version here to 7.3.3-bin and bwc test did pass for me. Can you try it out and let us know if it resolves the issue?

>>$ ./gradlew bwcTestSuite -Dtests.security.manager=false

FAILURE: Build failed with an exception.

* Where:
Build file '/home/ubuntu/security/bwc-test/build.gradle' line: 34

* What went wrong:
A problem occurred evaluating root project 'bwc-test'.
> Failed to apply plugin 'nebula.info-basic'.
   > Cannot obtain value from provider of system property 'user.name' at configuration time.
     Use a provider returned by 'forUseAtConfigurationTime()' instead.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 538ms

With 7.3.3-bin gradle version

>>$ ./gradlew bwcTestSuite -Dtests.security.manager=false
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 7.3.3
  OS Info               : Linux 5.11.0-1020-aws (amd64)
  Runtime JDK Version   : 14 (Private Build JDK)
  Runtime java.home     : /usr/lib/jvm/java-14-openjdk-amd64
  Gradle JDK Version    : 14 (Private Build JDK)
  Gradle java.home      : /usr/lib/jvm/java-14-openjdk-amd64
  Random Testing Seed   : 54CC66F17E2A5183
  In FIPS 140 mode      : false
=======================================

BUILD SUCCESSFUL in 1m 15s
8 actionable tasks: 8 executed

@dbwiddis
Copy link
Member

The change causing this failure was part of the 11.3.3 release in this PR, which removed the graceful fallback. nebula-plugins/gradle-info-plugin#97

Looking into appropriate resolution.

@dbwiddis
Copy link
Member

This appears to have been a bug in Gradle 6.X which was fixed in Gradle 7: gradle/gradle#13333

The failing github action in the link was running on Gradle 6.9.

Believe no action is required here other than to ensure Gradle 7.x+ is used to build.

@dbwiddis
Copy link
Member

Another PR related to the same package: #3250

@saratvemulapalli This seems unrelated. Different plugin, different error message.

I'll be reviewing the gradle wrapper configs site-wide.

@dbwiddis
Copy link
Member

Identified3 plugins using 6.x gradle wrapper. Will submit PRs to update.

@dbwiddis
Copy link
Member

dbwiddis commented Jul 5, 2022

Closing this issue:

  • The version is already updated in OpenSearch and has been shown not to have issues with Gradle 7+
  • PR submitted to opensearch.build to upgrade there
  • data-prepper already upgraded
  • perftop has older version but doesn't build due to other compatibilities; project appears currently unmaintained to address these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Build Libraries & Interfaces Priority-Medium v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

No branches or pull requests

6 participants