Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JavaVersion in favour of standard Runtime.Version #3003

Closed
reta opened this issue Apr 20, 2022 · 1 comment · Fixed by #3006
Closed

Remove JavaVersion in favour of standard Runtime.Version #3003

reta opened this issue Apr 20, 2022 · 1 comment · Fixed by #3006
Assignees
@reta
Labels
Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request v2.1.0 Issues and PRs related to version 2.1.0 v3.0.0 Issues and PRs related to version 3.0.0

Comments

@reta
Copy link
Collaborator

reta commented Apr 20, 2022

Is your feature request related to a problem? Please describe.
Since JDK-9, the JDK provide standard means to manipulate runtime version using Runtime and Runtime.Version.

Describe the solution you'd like
Remove JavaVersion in favour of standard Runtime.Version

Describe alternatives you've considered
Keep this duplicate hierarchy of classes

Additional context
Since 2.0 set JDK-11 as baseline, we could use Runtime.Version and drop all checks for JDK-8/9/10
@reta reta added enhancement Enhancement or improvement to existing feature or request v2.1.0 Issues and PRs related to version 2.1.0 v3.0.0 Issues and PRs related to version 3.0.0 labels Apr 20, 2022
@reta reta self-assigned this Apr 20, 2022
This was referenced Apr 20, 2022
Closed
Merged
@reta reta mentioned this issue Apr 21, 2022
Closed
10 tasks
@reta
Copy link
Collaborator Author

reta commented Apr 21, 2022

@nknize it would be good to get it in 2.0, wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reta reta

Labels
Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request v2.1.0 Issues and PRs related to version 2.1.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove JavaVersion, use builtin Runtime.Version to deal with runtime versions reta/OpenSearch
1 participant
@reta