Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BWC] How should support be handled for OpenSearch / Plugins versions? #3440

Closed
peternied opened this issue May 25, 2022 · 5 comments · Fixed by opensearch-project/opensearch-plugins#150
Labels
backwards-compatibility Plugins question Questions about how things work, requests for help

Comments

@peternied
Copy link
Member

With the release of 2.0.0, plugin branches are migrating to versions 2.1 and 3.0. Is there a recommendation for common settings for backwards compatibility?

We support the last major and the current previous major, so we should have tests for 1.3 -> 2.1 and 2.0 -> 2.1, can we make sure we test both?

stated differently, we should have tests that cover:

  • last supported major version (1) and its most recent minor version (3) to current version
  • current major version (2) and its most recent minor version (0) to current version

if we really wanted to be thorough I think we would add checks for every minor version on the current major version (e.g. if we were on 2.4, we would have BWC tests for 1.3, 2.0, 2.1, 2.2, and 2.3) (e.g.2 if we were on 3.1 we would have BWC tests for 2.3 and 3.0)

@peternied peternied added bug Something isn't working untriaged labels May 25, 2022
@peternied
Copy link
Member Author

We support the last major and the current previous major

I've made this statement and cannot find documentation to substantiate it. Does someone have a link, or is this something we need to codify?

@tlfeng tlfeng added question Questions about how things work, requests for help backwards-compatibility and removed bug Something isn't working untriaged labels May 25, 2022
@saratvemulapalli
Copy link
Member

saratvemulapalli commented May 25, 2022

Trying to understand the context.
Is the question tailored to plugins backwards compatibility testing?

Branching strategy is documented in https://github.com/opensearch-project/.github/blob/main/RELEASING.md#opensearch-branching. Are you looking for something similar:

  • Documented versions for BWC.
  • Automated validation of expected BWC versions [1]

[1] opensearch-project/opensearch-build#90

@peternied
Copy link
Member Author

[Recapping from offline conversation with @saratvemulapalli]

  • In future release of OpenSearch, the BWC tests versions targets will be supplied from as part of the distribution build, so all plugins will need to be updated to pull those versions from gradle properties. Plugins running BWC tests on there own is an option for early failure detection.

  • To setup these BWC tests for a plugin on its own, as version numbers are incremented, previous versions should be folded into the BWC test matrix, so if we had 1.3.0 for the 2.0.0 release, when we go to version 2.1.0 the matrix should now include 1.3.0 & 2.0.0. We should not remove/replace items from the BWC test matrix until they are no longer supported.

@dblock
Copy link
Member

dblock commented May 26, 2022

Is there anything else to this? Do we need to document something in https://github.com/opensearch-project/opensearch-plugins?

@peternied
Copy link
Member Author

@dblock I'll create a pull request in that repo to document then after it is merged this issue should be closed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-compatibility Plugins question Questions about how things work, requests for help
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants