Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remote Store] Make uploadMetadata private and call it internally from RemoteSegmentStoreDirectory #4171

Open
sachinpkale opened this issue Aug 9, 2022 · 0 comments
Open

[Remote Store] Make uploadMetadata private and call it internally from RemoteSegmentStoreDirectory #4171

sachinpkale opened this issue Aug 9, 2022 · 0 comments
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Remote

Comments

@sachinpkale
Copy link
Member

Describe the solution you'd like
As per the comment: #4020 (comment), uploadMetadata should not be a public method. This will allow to abstract it as part of RemoteSegmentStoreDirectory and callers will not have to understand how remoteMetadataDirectory works internally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Remote
Projects
Storage Project Board
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sachinpkale @Poojita-Raj @anasalkouz