Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release]: performance-analyzer-commons #3547

Closed
khushbr opened this issue May 23, 2023 · 14 comments
Closed

[release]: performance-analyzer-commons #3547

khushbr opened this issue May 23, 2023 · 14 comments

Comments

@khushbr
Copy link
Contributor

khushbr commented May 23, 2023

Did you read the on-boarding document

Yes

What is the name of your component?

performance-analyzer-commons

What is the link to your GitHub repo?

https://github.com/opensearch-project/performance-analyzer-commons

Targeted release date

05/30/2023

Where should we publish this component?

https://aws.oss.sonatype.org/content/repositories/snapshots/

What type of artifact(s) will be generated for this component?

Java JAR file

Have you completed the required reviews including security reviews, UX reviews?

Yes

Have you on-boarded automated security scanning for the GitHub repo associated with this component?

Yes

Additional context

opensearch-project/performance-analyzer-commons#2

@khushbr
Copy link
Contributor Author

khushbr commented May 23, 2023

performance-analyzer-commons

  • The library will be packaged, tested and released with the performance-analyzer plugin.
  • The library will be OpenSearch version agnostic.
  • The library does not have dependency on OpenSearch codebase.

Current ask is to Publish the repo source Java JAR to Maven Snapshot repo.

@khushbr
Copy link
Contributor Author

khushbr commented May 23, 2023

@gaiksaya @prudhvigodithi Adding you for comment, this library will closely follow the Data Prepper component.

@gaiksaya
Copy link
Member

I believe we just need to add the mentioned repo to our maven credentials access, generate and IAM role that will be used to publish to snapshots repository. Waiting for approval of this PR: opensearch-project/performance-analyzer-commons#11

@khushbr
Copy link
Contributor Author

khushbr commented May 23, 2023

@gaiksaya The PR has been merged, can you please add the repo for maven creds. Thank You!

@gaiksaya
Copy link
Member

This is an independent component which is follow it's only release cadence similar to other components like spring-data-opensearch, opensearch-java.
See the on-boarding documentation: https://github.com/opensearch-project/opensearch-build/blob/main/ONBOARDING.md#onboarding-to-universal--1-click-release-process

Sample PR: opensearch-project/spring-data-opensearch#74

Thanks!

@gaiksaya
Copy link
Member

@gaiksaya The PR has been merged, can you please add the repo for maven creds. Thank You!

Thanks! @zelinh Will be taking care of it.

@peterzhuamazon
Copy link
Member

peterzhuamazon commented May 23, 2023

Hi,
Some steps out of the offline meeting:

  • PA Commons Libs needs to be onboard to 1click process, and needs to be released before any build on Jenkins for PA.
  • PA Commons Libs has its own version scheme and PA team is responsible for the releases.
  • PA gradle task will take care of getting the jars that published above during build time and bundled into zip
  • Confirm PA RCA is now replaced fully by PA Commons Libs or not, which include following changes not limited to:
    • Config location, name
    • Folder location
    • Removal of original rca folder from root of artifacts
    • Impact on PA cli script that used to start the agent
    • All of the distributions except Windows will be impacted as their build/assemble/startup script is heavily coded according to the previous setups of RCA
    • Whether the plugin can handle the lib jar loading during runtime.
    • Log rotation and default log location

cc: @khushbr @gaiksaya

Thanks

@khushbr
Copy link
Contributor Author

khushbr commented May 23, 2023

#3548

@peterzhuamazon
Copy link
Member

peterzhuamazon commented May 23, 2023

@peterzhuamazon
Copy link
Member

The offline discussion with @khushbr confirms that both PA and RCA still there.
The only changes is to add the PA commons lib as an external lib.
Will wait for her to complete the code change, public the jar through 1 click release, and verify build.

Thanks.

@zelinh
Copy link
Member

zelinh commented May 30, 2023

We have completed onboarding 1-click release process from our side. Jenkins job is created. https://build.ci.opensearch.org/job/performance-analyzer-commons-release/

@gaiksaya
Copy link
Member

The validation checks failed:
image

@khushbr is looking into it

@gaiksaya
Copy link
Member

@khushbr
Copy link
Contributor Author

khushbr commented May 31, 2023

Release done for PA-Commons 1.0.0 - https://github.com/opensearch-project/performance-analyzer-commons/releases/tag/1.0.0

Thank you @gaiksaya , much appreciate all the prompt help for getting this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants