From 45a3adc8ad17fd7ab6e418e7a20ba6a4b8f7f3a6 Mon Sep 17 00:00:00 2001 From: Paul Sebastian Date: Tue, 10 Sep 2024 18:31:02 -0700 Subject: [PATCH] fixes observability dashboards tests (#1562) * observability test fixes Signed-off-by: Paul Sebastian * use milliseconds in time validation Signed-off-by: Paul Sebastian * remove html tag from data test subj Signed-off-by: Paul Sebastian * remove more html tags Signed-off-by: Paul Sebastian * fix notebook deletion Signed-off-by: Paul Sebastian --------- Signed-off-by: Paul Sebastian --- .../2_trace_analytics_services.spec.js | 2 +- .../3_trace_analytics_traces.spec.js | 5 +++-- .../plugins/observability-dashboards/6_notebooks.spec.js | 5 ++--- cypress/utils/plugins/observability-dashboards/constants.js | 4 +++- 4 files changed, 9 insertions(+), 7 deletions(-) diff --git a/cypress/integration/plugins/observability-dashboards/2_trace_analytics_services.spec.js b/cypress/integration/plugins/observability-dashboards/2_trace_analytics_services.spec.js index 7ad693834..fe30aec90 100644 --- a/cypress/integration/plugins/observability-dashboards/2_trace_analytics_services.spec.js +++ b/cypress/integration/plugins/observability-dashboards/2_trace_analytics_services.spec.js @@ -26,7 +26,7 @@ describe('Testing services table', () => { .first() .focus() .type(`${SERVICE_NAME}{enter}`); - cy.get('.euiButton__text').contains('Refresh').click(); + cy.get('[data-test-subj="superDatePickerApplyTimeButton"]').click(); cy.contains(' (1)').should('exist'); }); diff --git a/cypress/integration/plugins/observability-dashboards/3_trace_analytics_traces.spec.js b/cypress/integration/plugins/observability-dashboards/3_trace_analytics_traces.spec.js index ed67df8dc..bfd0f2b5e 100644 --- a/cypress/integration/plugins/observability-dashboards/3_trace_analytics_traces.spec.js +++ b/cypress/integration/plugins/observability-dashboards/3_trace_analytics_traces.spec.js @@ -29,13 +29,14 @@ describe('Testing traces table', () => { it('Searches correctly', () => { cy.get('input[type="search"]').focus().type(`${TRACE_ID}{enter}`); - cy.get('.euiButton__text').contains('Refresh').click(); + cy.get('[data-test-subj="superDatePickerApplyTimeButton"]').click(); cy.contains(' (1)').should('exist'); cy.get('.euiTableCellContent') .eq(11) .invoke('text') .then((text) => { - expect(dayjs(text, 'MM/DD/YYYY HH:mm:ss', true).isValid()).to.be.true; + expect(dayjs(text, 'MM/DD/YYYY HH:mm:ss.SSS', true).isValid()).to.be + .true; }); }); }); diff --git a/cypress/integration/plugins/observability-dashboards/6_notebooks.spec.js b/cypress/integration/plugins/observability-dashboards/6_notebooks.spec.js index c4f0bd896..d8904766c 100644 --- a/cypress/integration/plugins/observability-dashboards/6_notebooks.spec.js +++ b/cypress/integration/plugins/observability-dashboards/6_notebooks.spec.js @@ -34,7 +34,7 @@ const makeTestNotebook = () => { cy.contains(`Notebook "${notebookName}" successfully created`); - cy.get('h1[data-test-subj="notebookTitle"]') + cy.get('[data-test-subj="notebookTitle"]') .contains(notebookName) .should('exist'); @@ -61,8 +61,7 @@ const deleteNotebook = (notebookName) => { .find('input[type="checkbox"]') .check(); - cy.get('button[data-test-subj="notebookTableActionBtn"]').click(); - cy.get('button[data-test-subj="deleteNotebookBtn"]').click(); + cy.get('[data-test-subj="deleteSelectedNotebooks"]').click(); cy.get('input[data-test-subj="delete-notebook-modal-input"]').focus(); cy.get('input[data-test-subj="delete-notebook-modal-input"]').type('delete'); diff --git a/cypress/utils/plugins/observability-dashboards/constants.js b/cypress/utils/plugins/observability-dashboards/constants.js index f5fa4c532..5238ac634 100644 --- a/cypress/utils/plugins/observability-dashboards/constants.js +++ b/cypress/utils/plugins/observability-dashboards/constants.js @@ -80,7 +80,9 @@ export const setTimeFilter = (setEndTime = false, refresh = true) => { timeout: TIMEOUT_DELAY, }).type('{selectall}' + endTime, { force: true }); } - if (refresh) cy.get('.euiButton__text').contains('Refresh').click(); + if (refresh) { + cy.get('[data-test-subj="superDatePickerApplyTimeButton"]').click(); + } cy.wait(delayTime); };